Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure examples for 0.1 are valid or removed #22

Closed
cholmes opened this issue Mar 2, 2022 · 7 comments
Closed

Make sure examples for 0.1 are valid or removed #22

cholmes opened this issue Mar 2, 2022 · 7 comments
Assignees
Milestone

Comments

@cholmes
Copy link
Member

cholmes commented Mar 2, 2022

Right now our 'examples' were made by Tom, and I'm pretty sure are out of date with the tweaks we've made.

If there's code that can make a 0.1 example before we release it'd be great to include. But if not we should just remove the examples (perhaps we could do a 0.1.1 release with examples). If it's too much work to get an example just remove the example folder, or assign to me and I can do it.

@cholmes cholmes added this to the 0.1 milestone Mar 2, 2022
@TomAugspurger
Copy link
Collaborator

I can get the files updated.

@jorisvandenbossche
Copy link
Collaborator

At the moment, I think it is still a "valid" file. We didn't make incompatible changes to the spec up to now (and the file was already using WKT2 for the crs, and WKB for the geometries, it is only missing some optional fields).

@TomAugspurger
Copy link
Collaborator

Yep, I think that's right.

I'll wait for #21 to add the bounding box. We might want to include a second example that includes some of the complications raised there.

@jorisvandenbossche
Copy link
Collaborator

Yes, in general we will want a set of "reference test files" with various cases, I think.

@cholmes
Copy link
Member Author

cholmes commented Mar 3, 2022

Oh great, we talked through so much that I figured something must have changed, but I guess we mostly reiterated all that we had.

I'll leave this open just to be a final check before releasing 0.1.

@alasarr
Copy link
Collaborator

alasarr commented Mar 6, 2022

@TomAugspurger #21 merged, you can go ahead 💪

@TomAugspurger
Copy link
Collaborator

Closed by #24. #27 is still open, but the example should be compatible with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants