-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure examples for 0.1 are valid or removed #22
Comments
I can get the files updated. |
At the moment, I think it is still a "valid" file. We didn't make incompatible changes to the spec up to now (and the file was already using WKT2 for the crs, and WKB for the geometries, it is only missing some optional fields). |
Yep, I think that's right. I'll wait for #21 to add the bounding box. We might want to include a second example that includes some of the complications raised there. |
Yes, in general we will want a set of "reference test files" with various cases, I think. |
Oh great, we talked through so much that I figured something must have changed, but I guess we mostly reiterated all that we had. I'll leave this open just to be a final check before releasing 0.1. |
@TomAugspurger #21 merged, you can go ahead 💪 |
Right now our 'examples' were made by Tom, and I'm pretty sure are out of date with the tweaks we've made.
If there's code that can make a 0.1 example before we release it'd be great to include. But if not we should just remove the examples (perhaps we could do a 0.1.1 release with examples). If it's too much work to get an example just remove the example folder, or assign to me and I can do it.
The text was updated successfully, but these errors were encountered: