Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for geography column name option #175

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

cholmes
Copy link
Member

@cholmes cholmes commented Jul 21, 2023

As discussed in #172 (comment) this PR adds an option to name your column 'geography' and have readers assume your edges are spherical.

Copy link
Collaborator

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been following this very carefully so take my approval with a grain of salt; however, I do think this is a positive change that will result in fewer misinterpretations in the wild.

format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
@cholmes cholmes merged commit 22503a5 into main Jul 24, 2023
3 checks passed
@jorisvandenbossche jorisvandenbossche deleted the cholmes/geography-compatibility branch August 7, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants