Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet Geospatial Compatibility Recommendations #172

Merged
merged 10 commits into from
Jul 18, 2023
Merged

Conversation

cholmes
Copy link
Member

@cholmes cholmes commented Jun 7, 2023

Attempt to explain the idea of making parquet files that are compatible, but aren't GeoParquet, as a recommendation for data producers and readers.

Big questions:

  • Does the naming sound right? Are there alternatives?
  • Does it successfully walk the line of explaining this option but not making it a 'spec' where people would only implement it and say they make 'GeoParquet'.

I put it in 'format-specs', but could put it elsewhere or rename that directory.

Any other tweaks / feedback are welcome as well.

@cholmes cholmes marked this pull request as ready for review June 26, 2023 01:39
format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
cholmes and others added 2 commits June 26, 2023 11:45
Co-authored-by: Kyle Barron <kbarron@foursquare.com>
Co-authored-by: Kyle Barron <kbarron@foursquare.com>
Copy link
Contributor

@mojodna mojodna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for floating this. It's a nice compromise for those of us who don't control the development/deployment cycle of the readers/writers we use.

format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
format-specs/compatible-parquet.md Show resolved Hide resolved
format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
format-specs/compatible-parquet.md Outdated Show resolved Hide resolved
format-specs/compatible-parquet.md Show resolved Hide resolved
cholmes and others added 4 commits June 27, 2023 07:37
Co-authored-by: Seth Fitzsimmons <seth@mojodna.net>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Seth Fitzsimmons <seth@mojodna.net>
Co-authored-by: Seth Fitzsimmons <seth@mojodna.net>
Copy link
Collaborator

@alasarr alasarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for moving this forward @cholmes 👏

@cholmes cholmes merged commit e7e0be7 into main Jul 18, 2023
3 checks passed
@m-mohr m-mohr deleted the compatible-parquet branch July 18, 2023 15:39
@jatorre
Copy link
Contributor

jatorre commented Jul 24, 2023

Sorry for the delay in here, but it was me I think who expressed issues with the naming. It is hard to say if geometry is more common than geography. One way to overcome entirely this issue that we have done in CARTO is start using geo when we dont know if something might be a geometry or a geography, as it only implies that there is geospatial data, but without knowing if it is a geometry o a geography.

My 2 cents

cholmes added a commit that referenced this pull request Jul 24, 2023
* updates for geography column name option, as discussed in #172 (comment)

* Update format-specs/compatible-parquet.md

Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>

---------

Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants