-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Fix Error 500 on accessing /products page #12820
[BUU] Fix Error 500 on accessing /products page #12820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and should fix the issue.
I'm weary about this comment from @mkllnk though, we need to make sure this does not get overriden and somehow reverted by Transifex, on the next release.
But I think for now this should be the way to go 👍
Hey @chahmedejaz, The bug was reproduced in staging-UK. After staging this PR, we can see the product page renders again: When having one product only from the search results: In staging-FR: When having one product only from the search results: I'd say this fixes the issue 🎉 Since I'm not 100% sure manually editing transifex files is the best process, I'm moving to ready to go. Please feel free to merge @chahmedejaz or any other @openfoodfoundation/core-devs. |
Yeah @filipefurtad0, I agree that there's a chance this may create conflict if someone changes somewhere near this PR's changes in Transifex as well. I hope this won't be the case in the next release 🤞 If we want to eliminate the chance for the above, we would need to do these changes in Transifex itself and I don't have access for that 😓 |
💯 Fully aligned @chahmedejaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed these strings in Transifex and committed the changes to master. The result is the same. So I can close this PR now.
Context: https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1724767186657359
What? Why?
total
) being used inen_FR
anden_GB
locales.count
)What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):