[BUU] Fix Error 500 on accessing /products page

[chahmedejaz]

Context: https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1724767186657359

What? Why?

• Closes [BUU] Error 500 on accessing /products page #12819
• There's a wrong variable name (total) being used in en_FR and en_GB locales.
• This PR fixes this by replacing all instances with the correct variable name (count)

What should we test?

• Should be tested on UK and FR servers
• Choose English as the language
• Visit the products page
• It should be displayed without error
• Try to filter the products such that only one product is displayed in the table and the page should not break as well.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

[filipefurtad0]

This looks good and should fix the issue.

I'm weary about this comment from @mkllnk though, we need to make sure this does not get overriden and somehow reverted by Transifex, on the next release.

But I think for now this should be the way to go 👍

[filipefurtad0]

Hey @chahmedejaz,

The bug was reproduced in staging-UK. After staging this PR, we can see the product page renders again:

for en_GB.yml

When having one product only from the search results:

In staging-FR:

for en_FR.yml

When having one product only from the search results:

I'd say this fixes the issue 🎉

Since I'm not 100% sure manually editing transifex files is the best process, I'm moving to ready to go. Please feel free to merge @chahmedejaz or any other @openfoodfoundation/core-devs.

[chahmedejaz]

Since I'm not 100% sure manually editing transifex files is the best process

Yeah @filipefurtad0, I agree that there's a chance this may create conflict if someone changes somewhere near this PR's changes in Transifex as well. I hope this won't be the case in the next release 🤞

If we want to eliminate the chance for the above, we would need to do these changes in Transifex itself and I don't have access for that 😓
Given the access, I can try to make these changes via Transifex itself. However, I think Fixing this s1 is worth taking the above chance 😬. If we get the green signal from anyone from the deployments channel, then I'd merge it. If not, then I'm leaving this decision on @openfoodfoundation/core-devs. Thanks

[filipefurtad0]

If we get the green signal from anyone from the deployments channel, then I'd merge it

💯 Fully aligned @chahmedejaz

[mkllnk]

I changed these strings in Transifex and committed the changes to master. The result is the same. So I can close this PR now.