-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Pluralize admin products search result [OFN-12532]" #12730
Conversation
I just pulled the latest master branch and noticed a weird translation with |
Hey @wandji20, thanks for looking into this! The locale assigned to staging-FR is I've pulled the latest translations into master. Maybe I should re-stage master after this...
Which translation do you mean? |
1edf4a5
to
7939bf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 . It's a pretty safe change so I am going to merge it now to not block the release
Thanks @rioug for reverting the PR.
In any case, I agree with @wandji20, this does not seem right. Now we've gone down the path of reverting this PR, so I think we'd need to revert the latest translations from master too, 0afbdf1. Right? |
I am not sure to be honest. I think if this fix the problematic translations we should be good as it is. @openfoodfoundation/core-devs any input ? |
Thanks for spotting this Wandji. Indeed, All other changes in that commit look valid. But it's interesting that a lot of valid translations were also removed, for example: 0afbdf1#diff-e76a11e9b4a84e1653a37d620ec4ce380841d3763e51f37e5a415a5a7d21a028L758
Going forward, I think we could fix this up by manually fixing the dodgy translation changes. As far as I understand, it's appropriate in this case to manually edit the translation files. @wandji20, would you be interested to try that, or should I? |
I think that any manual edits would get overridden through Transifex again. Manual updates have to happen in Transifex. Next time we should rename the translation key if we change the parameter variable names. It may just be that translations were not updated yet and still using the old variable which then results in a server error. |
I have opened a PR with this change. |
Closes #12731.
Reverts #12665.