-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Error 500 on accessing /products page #12819
Comments
Thanks for pointing out the Bugsnag error @BethanOFN:
Edit: this is related to locales, see discussion here. Thanks @chahmedejaz for investigating! Also mentioned here. |
Bumping to S1 as it seems to affect all UK users, and rolling back BUU is not an great workaround. |
The issue is easily reproducible in staging-UK, a heads-up to @openfoodfoundation/testers we'll need to use this server to test the PR fixing it. (PS: feel free to ping if you need early testing on your upcoming PR @chahmedejaz.) |
Together with @chahmedejaz, we've manually edited the However I think it's a good idea to leave this issue open as any deployment will probably undo these changes and break the page again. So we'll need to decide whether we go for this solution or fix it via Transifex. |
A pull request would fix this only to the next release when we pull translations from Transifex again. We need to fix this in Transifex because that's our source of truth. Looking at the history of the files, I'm trying to work out what went wrong:
Looking at the Transifex interface, there's no way to edit the variable. You can only copy it from source or use a suggestion. So unfortunately, Transifex must have suggested the wrong version. Starting the translation for en_AU from scratch, it has several suggestions. The first one is correct but the other ones are wrong. It may also be that our previous renaming of the key confused the Transifex AI. How do we prevent this in the future? Translators need to be more careful with suggestions. If something like this happens again, I would also raise it with Transifex. They should ensure that the translation contains only variables from the original string. |
The changes have now been done in Transifex and master. This problem should be solved. |
Description
Users can't access the /products page.
This seems to affect UK instance only (so far?)
Expected Behavior
The products page should render and display the products list.
Actual Behaviour
Users are getting an error 500.
Steps to Reproduce
Animated Gif/Screenshot
Workaround
Disable admin_v3 feature toggle.
Severity
bug-s2: a non-critical feature is broken, no workaround
Your Environment
Possible Fix
The text was updated successfully, but these errors were encountered: