fix: issue #3133 backbutton visible now

[Akashsri3bi]

What

BackButton Visible now in LightMode

Screenshot

@M123-dev .

[codecov-commenter]

Codecov Report

Merging #3137 (916f43b) into develop (d49c2bc) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop   #3137   +/-   ##
=======================================
  Coverage     6.40%   6.40%           
=======================================
  Files          247     247           
  Lines        12324   12324           
=======================================
  Hits           789     789           
  Misses       11535   11535           

Impacted Files	Coverage Δ
...pp/lib/generic_lib/widgets/smooth_back_button.dart	7.14% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[M123-dev]

Heyy @Akashsri3bi this change works for the search page, but would break other pages, as this SmoothBackButton is also used in the ProductPage and the image gallery so just changing it will break this. Though I think it makes sense to make this Widget work for the normal AppBar.

My suggestion:

• Add a optional inverted bool to the SmoothBackButton
• Make the color `color: iconColor ?? (inverted ? Colors.white : Colors.black),
• Make all the usage in product_image_viewer.dart new_product_page.dart & product_image_gallery_view.dart inverted

[Akashsri3bi]

Okay I will look into it

[Akashsri3bi]

Using Theme It now works as expected , I tried to go for approach inverted bool but got stuck somewhere and that's why I found a way around hope it seems ok @M123-dev

[Akashsri3bi]

The recent commit also fixes the issue #2988 ( The secondary button is hard to differentiate from text )

• implemented row style , gave button a border 1 px

[g123k]

The recent commit also fixes the issue #2988 ( The secondary button is hard to differentiate from text )

• implemented row style , gave button a border 1 px

Hello,

Please make this second feature another PR.
Basically 1 PR = 1 feature.

thanks