Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: The secondary button is hard to differentiate from text #2988

Closed
M123-dev opened this issue Sep 9, 2022 · 5 comments · Fixed by #3171
Closed

Discussion: The secondary button is hard to differentiate from text #2988

M123-dev opened this issue Sep 9, 2022 · 5 comments · Fixed by #3171
Assignees
@Akashsri3bi
Labels
buttons 🎨 Mockup required 🎨 UI / UX
Milestone
v4.1

Comments

@M123-dev
Copy link
Member

M123-dev commented Sep 9, 2022 •
edited by teolemon
Loading

What

Image

Screenshot_20220909-104145_OpenFoodFacts

It should be highlighted in some way, maybe @g123k has a suggestion for that
@monsieurtanuki monsieurtanuki mentioned this issue Sep 12, 2022
Open
@teolemon teolemon changed the title Discussion: The secondary button is hard to differntiate from text Discussion: The secondary button is hard to differentiate from text Sep 18, 2022
@Akashsri3bi
Copy link
Contributor

I would like to work on this issue . But which secondary button are you talking about

@M123-dev
Copy link
Member Author

Sure @Akashsri3bi, "Products to be completed" is a TextButton, but it really looks like text, we could put "Okay" and this together into a row as we do on other dialogs. We have a dedicated widget for that maybe have a look at the other dialogs

@Akashsri3bi
Copy link
Contributor

Okay Great !! Thanks

@teolemon
Copy link
Member

We could add a 1 pixel line around the button ?

@monsieurtanuki
Copy link
Contributor

Something like that then (https://stackoverflow.com/questions/50083390/create-a-button-with-rounded-border)
Capture d’écran 2022-10-14 à 18 14 07

@Akashsri3bi Akashsri3bi mentioned this issue Oct 14, 2022
Closed
@M123-dev M123-dev linked a pull request Oct 18, 2022 that will close this issue
fix: secondary button now differentiable issue #2988 #3171
Merged
@M123-dev M123-dev mentioned this issue Oct 18, 2022
Merged
M123-dev pushed a commit that referenced this issue Nov 2, 2022
@Akashsri3bi
fix: secondary button now differentiable issue #2988 (#3171)
cfb5137 
* fix: secondary button now differentiable

* fix: changes to secondary button issue

* changes

* fix: In accordance with theme now

* fix: improved secondary button as required

* fix: updates on secondarybutton
@github-actions github-actions bot mentioned this issue Nov 2, 2022
Merged
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akashsri3bi Akashsri3bi

Labels
buttons 🎨 Mockup required 🎨 UI / UX
Projects
🎨 UXR & Design team
Archived in project
Milestone
v4.1
Development

Successfully merging a pull request may close this issue.

fix: secondary button now differentiable issue #2988 Akashsri3bi/smooth-app
4 participants
@teolemon @monsieurtanuki @M123-dev @Akashsri3bi