Chart changes #438
Merged
Chart changes #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
niladrih
commented
Mar 15, 2024
•
niladrih
commented
- add README.md helm-docs template for crds subchart
- add values to toggle install of all CRDs
- coreutils to nix-shells
- add value option to toggle installation of snapshot CRDs
- refactor generate-readme.sh script to work with CRDs subchart
- add templates to crds chart to avoid installation if CRDs already exists, because otherwise install/upgrade fails because these template-style CRDs carry a release-name label.
- remove CRD-install functionality during upgrade, as the above templating takes care of that at install/upgrade time.
niladrih
requested review from
tiagolobocastro,
rohan2794 and
Abhinandan-Purkait
niladrih
force-pushed
the
crds-subchart-changes
branch
5 times, most recently
from
1dbc8e7
to
74f167d
Compare
niladrih
force-pushed
the
crds-subchart-changes
branch
2 times, most recently
from
ebd313c
to
39126f4
Compare
This was referenced Mar 16, 2024
niladrih
force-pushed
the
crds-subchart-changes
branch
2 times, most recently
from
6808447
to
8479a82
Compare
niladrih
force-pushed
the
crds-subchart-changes
branch
from
8479a82
to
37d1973
Compare
tiagolobocastro
approved these changes
Mar 20, 2024
abhilashshetty04
approved these changes
Mar 21, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
438: Chart changes r=niladrih a=niladrih - add README.md helm-docs template for crds subchart - add values to toggle install of all CRDs - coreutils to nix-shells - add value option to toggle installation of snapshot CRDs - refactor generate-readme.sh script to work with CRDs subchart - add templates to crds chart to avoid installation if CRDs already exists, because otherwise install/upgrade fails because these template-style CRDs carry a release-name label. - remove CRD-install functionality during upgrade, as the above templating takes care of that at install/upgrade time. Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
|
bors cancel |
- add README.md helm-docs template for crds subchart - add values to toggle install of all CRDs - coreutils to nix-shells - add value option to toggle installation of snapshot CRDs - refactor generate-readme.sh script to work with CRDs subchart Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
The CRDs in the helm chart have been moved to a subchart. They live in the subchart's 'templates' directory. They have templates which disables their installation if a CRD with the exact same name is already present in the kubernetes cluster. Thus, unless explicitly disabled, all templates are installed during helm upgrade. This functionality is no longer required. Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
force-pushed
the
crds-subchart-changes
branch
from
37d1973
to
4f1168c
Compare
|
bors merge |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.