Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(charts): move CRDs to a subchart #284

Merged
merged 9 commits into from
Mar 21, 2024

Conversation

niladrih
Copy link
Member

Changes:

  • bumps chart version, appVersion, image tag.
  • moves CRDs into a subchart and adds templating to enable/disable them, while maintaining install order. Install order matters for CRDs in case there are CRs inside the chart which may require the CRDs.
  • Add templating to CRDs which disables their installation if they already exist. Because the CRDs are inside the template directory of the subchart, they will carry the release-name label from helm. This makes them difficult to patch into an existing CRD in the cluster. The install/upgrade errors out in these cases. The templating will make sure the CRDs will be installed only if they are not present.

PRs with similar change:

@Abhinandan-Purkait
Copy link
Member

@niladrih We might want to consider this PR.
#258

@Abhinandan-Purkait
Copy link
Member

@niladrih You also need to change this file probably. https://github.com/openebs/lvm-localpv/blob/develop/deploy/lvm-operator.yaml and then we can go for a test?

@niladrih
Copy link
Member Author

@niladrih You also need to change this file probably. https://github.com/openebs/lvm-localpv/blob/develop/deploy/lvm-operator.yaml and then we can go for a test?

Put it in a different PR: #286

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (f3e9cd0) to head (a1d4915).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #284       +/-   ##
============================================
+ Coverage    23.50%   98.29%   +74.79%     
============================================
  Files           12        1       -11     
  Lines         3008      529     -2479     
============================================
- Hits           707      520      -187     
+ Misses        2288        5     -2283     
+ Partials        13        4        -9     
Flag Coverage Δ
bddtests 98.29% <ø> (+0.53%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niladrih niladrih force-pushed the 4.0-chart branch 2 times, most recently from 1e809bf to d7d4c71 Compare March 19, 2024 11:34
niladrih and others added 9 commits March 19, 2024 20:51
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih niladrih merged commit de4570f into openebs:develop Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants