-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade-job): add support for loki-stack helm chart upgrade #396
Conversation
9ee59be
to
831e0c5
Compare
I don't think this is a good idea, enabled and persistence are in loki, we should not modify these. |
The enabled is in |
I agree that persistence block items should be taken forward. |
920c327
to
2e74712
Compare
2e74712
to
0f699d3
Compare
This change now handles loki-stack helm chart update like it handles other changes to helm chart default values: it sets the new values to the final values manually. |
0f699d3
to
86dd407
Compare
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
- removes .loki-stack.loki.config.ingester.lifecycler.ring.kvstore as it does not exist in loki-stack v2.9.11 - adds set value for the grafana/loki container image tag - removes .loki-stack.promtail.config.snippets.extraClientConfigs as it does not exist in loki-stack v2.9.11 - removes .loki-stack.promtail.initContainer as it does not exist in loki-stack v2.9.11 - migrates .loki-stack.promtail.config.lokiAddress to .loki-stack.promtail.config.clients - adds yq command_output helper function - add set value for .loki-stack.promtail.readinessProbe.httpGet.path - migrate .loki-stack.promtail.config.snippets.extraClientConfigs to .loki-stack.promtail.config.clients Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
…tainer Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
bors merge |
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Build succeeded: |
Requires #386.
Overview:
loki-stack
and sethealth_check_targets: false
. #386. Introduces migrations and set_literal_value updates to alter the existing yaml till it resembles the new one.&Path
is thehelm::yaml::yq
module withAsRef<Path>
.Changes:
does not exist in loki-stack v2.9.11
does not exist in loki-stack v2.9.11
v2.9.11
.loki-stack.promtail.config.clients