-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loki-stack
and set health_check_targets: false
.
#386
Conversation
3eebd08
to
53eae7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reitermarkus You need to remove the .
from your commit message for the commit lint.
Also lowercase update |
@reitermarkus, also please regenerate the docs:
We need to add this to GHA too I guess, I'll fix this on another PR. |
387: Cherry-pick #386 r=tiagolobocastro a=tiagolobocastro Cherry-pick PR386 ## Description Fixes issue where promtail is never ready when no related Mayastor pod is running on a given node. ## Motivation and Context <! Co-authored-by: Markus Reiter <me@reitermark.us>
Given #387 is merged, should I still update this PR? |
Yes please, 387 was merged to the release branch, this is targetting develop |
Signed-off-by: Markus Reiter <me@reitermark.us>
53eae7f
to
b5c294d
Compare
@niladrih PTAL and sequence merge whichever way you think is better for the upgrade changes |
bors merge |
Build succeeded: |
396: feat(upgrade-job): add support for loki-stack helm chart upgrade r=niladrih a=niladrih Requires #386. Overview: - adds new yq commands to delete objects, append to objects, and append to arrays. - adds special upgrade values.yaml update for loki-stack changes from #386. Introduces migrations and set_literal_value updates to alter the existing yaml till it resembles the new one. - replaces all `&Path` is the `helm::yaml::yq` module with `AsRef<Path>`. Changes: - removes .loki-stack.loki.config.ingester.lifecycler.ring.kvstore as it does not exist in loki-stack v2.9.11 - adds set value for the grafana/loki container image tag - removes .loki-stack.promtail.config.snippets.extraClientConfigs as it does not exist in loki-stack v2.9.11 - removes .loki-stack.promtail.initContainer as it does not exist in loki-stack v2.9.11 - migrates .loki-stack.promtail.config.lokiAddress to .loki-stack.promtail.config.clients - adds yq command_output helper function - add set value for .loki-stack.promtail.readinessProbe.httpGet.path - migrate .loki-stack.promtail.config.snippets.extraClientConfigs to .loki-stack.promtail.config.clients Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Description
Motivation and Context
Fixes openebs/mayastor#1560.
Regression
No.
How Has This Been Tested?
Running with current helm chart and this configuration:
The
{{- tpl .Values.config.snippets.extraServerConfigs . | nindent 2 }}
part is included by default in newer versions of theloki-stack
chart.Types of changes
Checklist: