Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing and Platform fixes #782

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Tracing and Platform fixes #782

merged 2 commits into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. fix(agents/core): use tracing api 

    Incorrect log api was used for error logging.
Also include error source in the service error.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6291acd View commit details
    Browse the repository at this point in the history

  2. feat(platform): support custom namespace 

    When we run outside of the cluster, we can't just use the env to determine
the correct namespace..
For now we expose an additional method which allows overriding it.
A better solution is perhaps to simply ensure we create clients with the
correct namespace as default?

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    251f682 View commit details
    Browse the repository at this point in the history