Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing and Platform fixes #782

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Tracing and Platform fixes #782

merged 2 commits into from
Mar 14, 2024

Conversation

tiagolobocastro
Copy link
Contributor

@tiagolobocastro tiagolobocastro commented Mar 14, 2024

feat(platform): support custom namespace

When we run outside of the cluster, we can't just use the env to determine
the correct namespace..
For now we expose an additional method which allows overriding it.
A better solution is perhaps to simply ensure we create clients with the
correct namespace as default?

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

fix(agents/core): use tracing api

Incorrect log api was used for error logging.
Also include error source in the service error.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

Incorrect log api was used for error logging.
Also include error source in the service error.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
When we run outside of the cluster, we can't just use the env to determine
the correct namespace..
For now we expose an additional method which allows overriding it.
A better solution is perhaps to simply ensure we create clients with the
correct namespace as default?

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro tiagolobocastro changed the title fix(agents/core): use tracing api Tracing and Platform fixes Mar 14, 2024
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit a160da4 into develop Mar 14, 2024
8 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the tracing branch March 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants