Configuration proposal #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This OTEP is the result of the Configuration working group. See open-telemetry/opentelemetry-specification#2920 for additional details. cc @MrAlias @jack-berg Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/config
branch
from
c9fb1a5
to
86b65ac
Compare
jack-berg
approved these changes
Feb 23, 2023
tsloughter
approved these changes
Feb 23, 2023
srikanthccv
reviewed
Feb 23, 2023
srikanthccv
reviewed
Feb 23, 2023
jaronoff97
approved these changes
Feb 23, 2023
dashpole
reviewed
Feb 23, 2023
yurishkuro
reviewed
Feb 23, 2023
yurishkuro
reviewed
Feb 23, 2023
Signed-off-by: Alex Boten <aboten@lightstep.com>
svrnm
reviewed
Feb 24, 2023
|
Left a pair of comments but overall LGTM. One thing I'm curious about though, is how to individually enable/disable instrumentation libraries (which currently is exposed by both Java and DotNet auto instrumentation), e.g. cc @pellared |
yurishkuro
reviewed
Feb 24, 2023
Signed-off-by: Alex Boten <aboten@lightstep.com>
|
@open-telemetry/dotnet-instrumentation-maintainers PTAL |
reyang
reviewed
Feb 24, 2023
reyang
reviewed
Feb 24, 2023
reyang
reviewed
Feb 24, 2023
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
reyang
reviewed
Feb 24, 2023
tylerbenson
approved these changes
Mar 22, 2023
Co-authored-by: Tyler Benson <tylerbenson@gmail.com>
|
@open-telemetry/specs-approvers We have reached enough approvals for this PR (after extensive feedback cycles). Please review it, and otherwise I will merge it in the next couple of days. |
arminru
reviewed
Mar 27, 2023
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
jeremydvoss
reviewed
Mar 27, 2023
|
We got a pair of comments in the last days, which are covered in the "Further Discussion", so we are aware we need tuning there. Otherwise we are good to go. |
jack-berg
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Apr 12, 2023
Initial followup to [OTEP #225](open-telemetry/oteps#225). This lays the initial groundwork for file configuration in the specification. There are placeholders TODOs for many various followup tasks. Additional work is also needed to figure out how to merge [SDK Configuration](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-configuration.md), [SDK Environment Variables](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md) and file configuration into a cohesive story. This PR proposes the configuration schema live in `opentelemetry-specification/specification/configuration/schema/`, which implies that at some point additional build steps will be needed to confirm changes to the schema are valid and allowed. cc @MrAlias, @codeboten
This was referenced Apr 24, 2023
3 tasks
pyohannes
pushed a commit
to pyohannes/oteps
that referenced
this pull request
May 23, 2023
* Configuration proposal This OTEP is the result of the Configuration working group. See open-telemetry/opentelemetry-specification#2920 for additional details.
jack-berg
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Oct 16, 2023
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3360.
jack-berg
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Dec 14, 2023
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3437. The adds the YAML file format, and leaves an open TODO for the JSON format discussed in the original OTEP. It also define environment variable substitution. IMO its necessary to define environment variable substitution at the same time as file format because they interact in ways that aren't immediately obvious and need to be prototyped. The opentelemetry-java implementation of file configuration already accepts YAML encoding and performs environment variable substitution as described in this PR. It does not support JSON, and I don't think we should unless there is good reason. I omitted the JSON file format because I don't know of any prototypes that permit it. We should add JSON once a language implements it and explores how environment variable substitution works with JSON.
49 tasks
jack-berg
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Jan 29, 2024
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3744. This defines how file configuration works with custom SDK extension components (Samplers, Exporters, etc). It defines the concept of a Component Provider: - Component providers are registered with the type of extension component they provide and a name. Component providers are registered automatically or manually based on what is idiomatic in the language. - Component providers have a Create Plugin method, which passes configuration properties as a parameter and returns the configured component - When Create is called to interpret a file configuration model, and it comes across a reference to a extension component which is not built-in, it invokes Create Plugin on the corresponding component provider. If no corresponding component provider exists, or if Create Plugin returns an Error, Create returns an error. Prototype implementation in java here: open-telemetry/opentelemetry-java-examples#227 cc @open-telemetry/configuration-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This OTEP is the result of the Configuration working group. See open-telemetry/opentelemetry-specification#2920 for additional details.
cc @MrAlias @jack-berg
On-going prototypes: