Skip to content

Commit

Permalink
fix errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Boten committed Feb 23, 2023
1 parent 4569a89 commit c9fb1a5
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions text/0225-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ Configuration files *MUST* support environment variable expansion. While this ac
The syntax for environment variable expansion mirrors the [collector](https://opentelemetry.io/docs/collector/configuration/#configuration-environment-variables).

For example, given an environment where `API_KEY=1234`, the configuration file contents:
```

```yaml
scheme_version: 0.1
sdk:
tracer_provider:
Expand All @@ -288,7 +289,8 @@ sdk:
```
Result in the following after substitution:
```
```yaml
scheme_version: 0.1
sdk:
tracer_provider:
Expand Down Expand Up @@ -339,10 +341,6 @@ Configuration files provide an opportunity for misconfiguration. A way to mitiga
The working group looked to the OpenTelemetry Collector and OpenTelemetry Operator for inspiration and guidance.
## Configuration through environment variables supports runtime replacement of variables, would file based configuration require users to hardcode potentially sensitive values?

Hardcoding secrets in files is never a good idea. To address this

### Alternative schema languages
In choosing to recommend JSON schema, the working group looked at the following options:
Expand Down

0 comments on commit c9fb1a5

Please sign in to comment.