Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to point to new semconv artifact #3239

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

jack-berg
Copy link
Member

No description provided.

@jack-berg jack-berg requested review from a team September 8, 2023 16:58
@jack-berg
Copy link
Member Author

Would be great if we could have this version automatically update when new releases are published. Any tips from the maintainers on how to extend the auto-update-versions.yml github workflow with a new version? Is extending it as simple as it looks?

@cartermp
Copy link
Contributor

cartermp commented Sep 8, 2023

@jack-berg yeah, it should be pretty simple to update. I think the main concern is further changes that require code updates? One of the reasons why we have the existing ones auto-update is because the large majority of the time it's just the version number that has to update. If that's the case for semconv artifacts for Java, then I'd be in favor of automating it.

@jack-berg
Copy link
Member Author

@cartermp code changes are possible since the artifact is still alpha, but this was previously the case as well. For the most part, each release will be just a version bump. I'll make sure to followup in the rare event that a version bump coincides with a code change.

@cartermp
Copy link
Contributor

Sounds good @jack-berg -- looks like a PR I merged introduced a merge conflict. Once that's done and you can update the refcache with npm run-and-fix then this should be good to go.

@svrnm svrnm merged commit cd0e187 into open-telemetry:main Sep 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants