Rework java manual instrumentation #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
chalin
reviewed
Aug 8, 2023
breedx-splk
reviewed
Aug 8, 2023
breedx-splk
reviewed
Aug 8, 2023
jack-berg
reviewed
Aug 8, 2023
Signed-off-by: svrnm <neumanns@cisco.com>
55 tasks
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
svrnm
commented
Sep 11, 2023
svrnm
commented
Sep 11, 2023
jack-berg
reviewed
Sep 12, 2023
mateuszrzeszutek
approved these changes
Sep 13, 2023
|
Applied additional changes to solve conflict with #3239 |
Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
This was referenced Sep 13, 2023
This was referenced Sep 14, 2023
|
@breedx-splk @jack-berg @mateuszrzeszutek @chalin @cartermp thanks for reviewing this PR, it was a major effort to get this through :-) It's not perfect, but it moves the needle for having a more consistent documentation, thank you so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@open-telemetry/java-approvers @open-telemetry/docs-approvers
As mentioned this is a try to improve the manual instrumentation docs for Java. I used the updated version for JavaScript as a blueprint and I put the auto-configuration at the top.
There is still some work that needs to be done, but I would appreciate some early feedback. Thanks!
Preview:
https://deploy-preview-3144--opentelemetry.netlify.app/docs/instrumentation/java/manual/
Additional pages that will be introduced:
https://deploy-preview-3144--opentelemetry.netlify.app/docs/instrumentation/java/exporters/
https://deploy-preview-3144--opentelemetry.netlify.app/docs/instrumentation/java/libraries/ (tbd)