Minor clarification on BatchExportingProcessor behavior #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
approved these changes
Jul 26, 2024
pellared
added
spec:trace
tsloughter
requested changes
Jul 26, 2024
Co-authored-by: Tristan Sloughter <tristan@sloughter.dev>
jmacd
approved these changes
Jul 26, 2024
lzchen
approved these changes
Jul 29, 2024
lalitb
approved these changes
Jul 30, 2024
trask
approved these changes
Jul 30, 2024
|
@tsloughter Could you take another look to see if the wording looks good? |
|
Still need more reviews from @open-telemetry/technical-committee , could you help? |
|
@open-telemetry/technical-committee Please review/merge! Thanks. |
|
@open-telemetry/technical-committee @arminru Gentle reminder to look at this when you get a chance! |
arminru
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I am unsure of the meaning of the current wording, so trying to clarify here. It looks like the current wording was intended to convey that export() should not be triggered until previous export() finished, even if the triggers (batch-size met etc.) are ready. But the current wording is confusing. I hope I interpreted it correctly and this fix address the confusing aspect. If not, happy to correct myself.
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary