Skip to content

Commit

Permalink
Minor clarification on BatchExportingProcessor behavior (#4164)
Browse files Browse the repository at this point in the history
Co-authored-by: Tristan Sloughter <tristan@sloughter.dev>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
  • Loading branch information
3 people committed Aug 19, 2024
1 parent b1febbb commit 0b3328b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ release.

### Traces

- Minor clarification on BatchExportingProcessor behavior.
([#4164](https://github.com/open-telemetry/opentelemetry-specification/pull/4164))

### Metrics

### Logs
Expand Down
8 changes: 3 additions & 5 deletions specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -703,9 +703,9 @@ This is an implementation of the `SpanProcessor` which create batches of finishe
spans and passes the export-friendly span data representations to the
configured `SpanExporter`.

The processor SHOULD export a batch when any of the following happens AND
`SpanProcessor#Export()` has not yet returned (for additional concurrency
details see the [Export() specification](#exportbatch)):
The processor SHOULD export a batch when any of the following happens AND the
previous export call has returned (for additional concurrency details see
the [Export() specification](#exportbatch)):

- `scheduledDelayMillis` after the processor is constructed OR the first span
is received by the span processor.
Expand All @@ -715,8 +715,6 @@ details see the [Export() specification](#exportbatch)):
- The queue contains `maxExportBatchSize` or more spans.
- `ForceFlush` is called.

If any of the above events occurs before `Export()` returns, the span processor
should wait until `Export()` returns before exporting the next batch.
If the queue is empty when an export is triggered, the processor MAY export
an empty batch OR skip the export and consider it to be completed immediately.

Expand Down

0 comments on commit 0b3328b

Please sign in to comment.