Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalize the overflow and cardinality limit interaction #3912

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Formalize the overflow and cardinality limit interaction #3912

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc15e9e
Formalize the overflow and cardinality limit interaction
reyang Feb 28, 2024
499a6c7
changelog
reyang Feb 28, 2024
6539e69
Update specification/metrics/sdk.md
reyang Feb 28, 2024
72b2b37
Update specification/metrics/sdk.md
reyang Feb 28, 2024
78c84e6
Update specification/metrics/sdk.md
reyang Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ release.

- Remove implementation specific specification from metric API.
([#3890](https://github.com/open-telemetry/opentelemetry-specification/pull/3890))
- Formalize the interaction between cardinality limit and overflow attribute.
([#3912](https://github.com/open-telemetry/opentelemetry-specification/pull/3912))

### Logs

Expand Down
6 changes: 3 additions & 3 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,9 +759,9 @@ independently aggregated because of the limit.

The SDK MUST create an Aggregator with the overflow attribute set
prior to reaching the cardinality limit and use it to aggregate events
for which the correct Aggregator could not be created. The maximum
number of distinct, non-overflow attributes is one less than the
limit, as a result.
for which the correct Aggregator could not be created. The SDK MUST provide the
guarantee that overflow does not happen if the maximum number of distinct,
reyang marked this conversation as resolved.
Show resolved Hide resolved
non-overflow attribute sets is less than or equal to the limit.

#### Synchronous instrument cardinality limits

Expand Down
Loading