Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize the overflow and cardinality limit interaction #3912

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Feb 28, 2024

Follow up based on the TC discussion and spec issue triage discussion: #3904 (comment).

Related to #3904 and #3905.

@reyang reyang requested review from a team February 28, 2024 20:03
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
reyang and others added 2 commits February 28, 2024 12:59
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@reyang reyang added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Feb 28, 2024
Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation in #3904 (comment)!

@reyang reyang merged commit 64f2340 into open-telemetry:main Mar 1, 2024
7 checks passed
@reyang reyang deleted the reyang/metrics-overflow-clarification branch March 1, 2024 20:46
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants