Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capture the fully qualified type name for raised exceptions in spans #3837

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Add capture the fully qualified type name for raised exceptions in spans #3837

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
96941a7
fix: capture the fully qualified type name for raised exceptions in s…
emdneto Apr 5, 2024
859e0bb
test: add test_record_exception_fqn
emdneto Apr 6, 2024
a06a30c
fix: remove mock from tests and improve get qualname
emdneto Apr 6, 2024
884d8ba
fix: improve if statements and hardcode exception_type in tests
emdneto Apr 8, 2024
5bfc127
chore: lint
emdneto Apr 8, 2024
44be8a4
Merge branch 'main' into issue_3824
tammy-baylis-swi Apr 8, 2024
3f975e2
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
emdneto Apr 8, 2024
9976fc0
chore: add changelog entry
emdneto Apr 8, 2024
18b28ea
chore: lint
emdneto Apr 9, 2024
755ac7c
Merge branch 'main' into issue_3824
xrmx Apr 9, 2024
4fae860
Merge branch 'main' into issue_3824
xrmx Apr 10, 2024
5f14c23
Merge branch 'main' into issue_3824
emdneto Apr 10, 2024
cc4f651
Merge branch 'main' into issue_3824
lzchen Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,9 +994,11 @@ def record_exception(
traceback.format_exception(
type(exception), value=exception, tb=exception.__traceback__
)
)
)
emdneto marked this conversation as resolved.
Show resolved Hide resolved
module = exception.__class__.__module__ if exception.__class__.__module__ != "builtins" else ""
emdneto marked this conversation as resolved.
Show resolved Hide resolved
exc_type = f"{module}.{exception.__class__.__qualname__}" if module else exception.__class__.__qualname__
_attributes: MutableMapping[str, types.AttributeValue] = {
"exception.type": exception.__class__.__name__,
"exception.type": exc_type,
"exception.message": str(exception),
"exception.stacktrace": stacktrace,
"exception.escaped": str(escaped),
Expand Down