Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capture the fully qualified type name for raised exceptions in spans #3837

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Add capture the fully qualified type name for raised exceptions in spans #3837

merged 13 commits into from
Apr 11, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Apr 5, 2024 •
edited
Loading

Fixes #3824

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py39-opentelemetry-sdk

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8

  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md

  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto requested a review from a team April 5, 2024 17:07
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

xrmx
xrmx reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add tests to check that it is working fine

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py Outdated Show resolved Hide resolved
@emdneto
Copy link
Member Author

emdneto commented Apr 6, 2024

Would be nice to add tests to check that it is working fine

@xrmx Thank you for your valuable review. I added a test and fixed the items you mentioned

@tammy-baylis-swi
Copy link
Contributor

Please could you also add a changelog line linking this PR.

@lzchen lzchen enabled auto-merge (squash) April 10, 2024 17:19
auto-merge was automatically disabled April 10, 2024 17:21

Pull Request is not mergeable

@emdneto emdneto changed the title fix: capture the fully qualified type name for raised exceptions in spans Add capture the fully qualified type name for raised exceptions in spans Apr 10, 2024
@emdneto
Copy link
Member Author

emdneto commented Apr 11, 2024

@lzchen any idea why auto-merge failed?

@lzchen lzchen merged commit 3acc474 into open-telemetry:main Apr 11, 2024
233 checks passed
@emdneto emdneto mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@ocelotl ocelotl ocelotl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exception.type should capture the fully qualified type name, not just the class name
5 participants
@emdneto @tammy-baylis-swi @xrmx @ocelotl @lzchen