Add buffer handlers and implement buffer metrics #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
breedx-splk,
jack-berg and
kittylyst
roberttoyonaga
changed the title
kittylyst
approved these changes
Dec 15, 2022
jack-berg
approved these changes
Dec 20, 2022
...java/io/opentelemetry/contrib/jfr/metrics/internal/buffer/DirectBufferStatisticsHandler.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public Optional<Duration> getPollingDuration() { | ||
| return Optional.of(Duration.ofSeconds(1)); |
There was a problem hiding this comment.
What's the significance of the polling duration? Why 1s vs. 5s, 10s, etc?
There was a problem hiding this comment.
The JFR streaming system flushes the in memory JFR buffers holding event data to the disk repo at 1s intervals, at which point they may be consumed by the handlers. So polling at 1s intervals should provide the most up to date data without adding unnecessary overhead.
jfr-streaming/src/test/java/io/opentelemetry/contrib/jfr/metrics/BufferMetricTest.java
Outdated
Show resolved
Hide resolved
jfr-streaming/src/test/java/io/opentelemetry/contrib/jfr/metrics/BufferMetricTest.java
Outdated
Show resolved
Hide resolved
jack-berg
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add handlers for buffer metrics
process.runtime.jvm.buffer.limit,process.runtime.jvm.buffer.count, andprocess.runtime.jvm.buffer.usage.This was a part of a larger PR here: #644.
jfr-streaming/src/main/java/io/opentelemetry/contrib/jfr/metrics/internal/Constants.javahas been kept the same as it was in the larger PR because it's used in all of the smaller constituent PRs. This will hopefully also avoid some conflicts as the PRs are sequentially merged. As a result, there are some constants that are defined, but not used in this PR.