[BUILD] Show warning message if WITH_OTLP is enabled #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 166 166
Lines 4784 4784
=======================================
Hits 4171 4171
Misses 613 613 |
lalitb
approved these changes
Apr 21, 2023
owent
approved these changes
Apr 22, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To resolve #1926, we'll remove
WITH_OTLPCMake option as we discussed. But this option could be used by users, so emit warning for now to about its deprecation.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes