Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] CMake option WITH_OTLP_GRPC not predictable, sometime not displayed. #1926

Closed
marcalff opened this issue Jan 16, 2023 · 1 comment · Fixed by #2112 or #2161
Closed

[BUILD] CMake option WITH_OTLP_GRPC not predictable, sometime not displayed. #1926

marcalff opened this issue Jan 16, 2023 · 1 comment · Fixed by #2112 or #2161
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

As seen with PR #1916, CMake option WITH_OTLP_GRPC needs some cleanup.

It should not be a cmake_dependent_option(), just a plain option().
@marcalff marcalff added the bug Something isn't working label Jan 16, 2023
@marcalff marcalff self-assigned this Jan 16, 2023
@marcalff marcalff changed the title [BUILD] Cmake option WITH_OTLP_GRPC not predictable, sometime not displayed. [BUILD] CMake option WITH_OTLP_GRPC not predictable, sometime not displayed. Jan 16, 2023
@marcalff marcalff removed their assignment Mar 12, 2023
@ThomsonTan ThomsonTan mentioned this issue Apr 21, 2023
Merged
3 tasks
@marcalff marcalff reopened this May 26, 2023
@marcalff
Copy link
Member Author

Reopen issue.

This was closed automatically by github because the issue number was mentioned in PR #2112, but the issue itself is not resolved.

@marcalff marcalff mentioned this issue May 26, 2023
Closed
@ThomsonTan ThomsonTan mentioned this issue May 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@marcalff