Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling relevant: minor improvements #70

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Sampling relevant: minor improvements #70

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2759314
Sampling relevant: MUST -> SHOULD
lmolkova Sep 24, 2021
4591635
Merge branch 'main' of https://github.com/open-telemetry/build-tools
lmolkova Sep 28, 2021
8829c1d
return MUST back
lmolkova Sep 28, 2021
f17a8fb
Merge branch 'main' into main
arminru Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,13 @@ def to_creation_time_attributes(
sampling_relevant_attrs: typing.List[SemanticAttribute],
output: io.StringIO,
):
"""Renders list of attributes that MUST be provided at creation time
"""Renders list of attributes that SHOULD be provided at creation time
:return:
"""
if sampling_relevant_attrs:
output.write(
"\nFollowing attributes MUST be provided **at span creation time** (when provided at all):\n\n"
"\nFollowing attributes SHOULD be provided **at span creation time** (when provided at all), " +
"so they can be considered for sampling decisions:\n\n"
)

for attr in sampling_relevant_attrs:
Expand Down
2 changes: 1 addition & 1 deletion semantic-conventions/src/tests/data/markdown/sampling_relevant/expected.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
| [`net.peer.name`](span-general.md) | string | . | `.` | No |
| [`net.peer.port`](span-general.md) | int | . | | No |

Following attributes MUST be provided **at span creation time** (when provided at all):
Following attributes SHOULD be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions:

* `http.method`
* `http.url`
Expand Down