Sampling relevant: minor improvements #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arminru addressing your comment open-telemetry/opentelemetry-specification#1916 (comment) |
|
It would be nice if these details were configurable with the Jinja template mechanism also for markdown, then we wouldn't have to spread out PRs over two repos which is quite cumbersome. EDIT: Created #71 |
Oberon00
approved these changes
Sep 24, 2021
Oberon00
added
semconv
arminru
reviewed
Sep 24, 2021
semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
Outdated
Show resolved
Hide resolved
|
@arminru I'm not sure we reached a consensus on must/should in the open-telemetry/opentelemetry-specification#1916. Let's not merge this one yet. Thanks! |
lmolkova
changed the title
arminru
approved these changes
Oct 13, 2021
|
@arminru @Oberon00 this is ready to go based on the discussion in open-telemetry/opentelemetry-specification#1916. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After additional discussion on open-telemetry/opentelemetry-specification#1916, making the population of sampling_relevant attributes recommended (SHOULD) instead of or required (MUST) for now.