Improve OpenAPI definition #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dvacca-onfido
commented
Jan 23, 2024
•
dvacca-onfido
commented
- Add missing verbs and models and remove standalone files when not necessary
- Make use of enums and pattern validators when possible
- Update README.md as well as YAML and JSON output files
- Align the sorting of the different endpoints with public documentation
dvacca-onfido
requested review from
DavidMealha-Onfido and
RiccardoPetteruti-Onfido
- Add missing verbs and models - Use constant enum instead of discrimitator to chose appropriate models for reports - Make use of enums and pattern validators when possible - Update YAML and JSON output file - Update README.md
dvacca-onfido
force-pushed
the
feature/improve_openapi_definition
branch
from
a0bf380
to
a14ff13
Compare
dvacca-onfido
commented
Jan 23, 2024
- Improve regex definitions for pattern validation - Use discriminator again and add enum for report types - Rebuild YAML and JSON definitions with precise openapi generator version (7.2.0)
dvacca-onfido
force-pushed
the
feature/improve_openapi_definition
branch
from
f523c39
to
f57d52a
Compare
DavidMealha-Onfido
approved these changes
Jan 26, 2024
dvacca-onfido
force-pushed
the
feature/improve_openapi_definition
branch
from
7985f55
to
401e073
Compare
dvacca-onfido
force-pushed
the
feature/improve_openapi_definition
branch
from
dc7283e
to
2aceb17
Compare
dvacca-onfido
commented
Jan 30, 2024
dvacca-onfido
force-pushed
the
feature/improve_openapi_definition
branch
from
5dfe625
to
6dbc01b
Compare
dvacca-onfido
force-pushed
the
feature/improve_openapi_definition
branch
from
6dbc01b
to
1c4add9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.