Changes after code review (4)

onfido · Jan 30, 2024 · 1c4add9 · 1c4add9
1 parent 2aceb17
commit 1c4add9
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 9 deletions.
diff --git a/generated/artifacts/openapi-yaml/openapi/openapi.yaml b/generated/artifacts/openapi-yaml/openapi/openapi.yaml
@@ -5545,12 +5545,18 @@ components:
           description: The SDK version that was used.
           type: string
         sdk_source:
-          description: "The SDK used to upload the media.\tonfido-android-sdk, onfido-ios-sdk,\
-            \ onfido-web-sdk"
+          description: The SDK used to upload the media.
+          enum:
+          - onfido-android-sdk
+          - onfido-ios-sdk
+          - onfido-web-sdk
           type: string
         authentication_type:
-          description: "The token used to authenticate the request.\tsdk_token, mobile_token,\
-            \ api_token"
+          description: The token used to authenticate the request.
+          enum:
+          - sdk_token
+          - mobile_token
+          - api_token
           type: string
         raw_model:
           description: The model as set by the phone manufacturer (for Android and
@@ -5596,6 +5602,10 @@ components:
           description: Whether there is highly suspicious traffic related to the IP
             address. The risk depends on the overall ratio of clear checks on a given
             IP.
+          enum:
+          - NOT_ENOUGH_DATA
+          - HIGH_RISK
+          - LOW_RISK
           type: string
         device_fingerprint_reuse:
           description: The number of times the device was used to create a report
@@ -5610,10 +5620,16 @@ components:
         document_capture:
           description: Whether the document media were live captured from the device
             camera.
+          enum:
+          - live
+          - unknown_method
           type: string
         biometric_capture:
           description: Whether the biometric media were live captured from the device
             camera.
+          enum:
+          - live
+          - unknown_method
           type: string
       type: object
     device_intelligence_breakdown_properties_ip:

diff --git a/generated/artifacts/openapi/openapi.json b/generated/artifacts/openapi/openapi.json
@@ -6450,11 +6450,13 @@
             "type" : "string"
           },
           "sdk_source" : {
-            "description" : "The SDK used to upload the media.\tonfido-android-sdk, onfido-ios-sdk, onfido-web-sdk",
+            "description" : "The SDK used to upload the media.",
+            "enum" : [ "onfido-android-sdk", "onfido-ios-sdk", "onfido-web-sdk" ],
             "type" : "string"
           },
           "authentication_type" : {
-            "description" : "The token used to authenticate the request.\tsdk_token, mobile_token, api_token",
+            "description" : "The token used to authenticate the request.",
+            "enum" : [ "sdk_token", "mobile_token", "api_token" ],
             "type" : "string"
           },
           "raw_model" : {
@@ -6503,6 +6505,7 @@
           },
           "ip_reputation" : {
             "description" : "Whether there is highly suspicious traffic related to the IP address. The risk depends on the overall ratio of clear checks on a given IP.",
+            "enum" : [ "NOT_ENOUGH_DATA", "HIGH_RISK", "LOW_RISK" ],
             "type" : "string"
           },
           "device_fingerprint_reuse" : {
@@ -6516,10 +6519,12 @@
           },
           "document_capture" : {
             "description" : "Whether the document media were live captured from the device camera.",
+            "enum" : [ "live", "unknown_method" ],
             "type" : "string"
           },
           "biometric_capture" : {
             "description" : "Whether the biometric media were live captured from the device camera.",
+            "enum" : [ "live", "unknown_method" ],
             "type" : "string"
           }
         },

diff --git a/schemas/reports/device_intelligence_breakdown.yaml b/schemas/reports/device_intelligence_breakdown.yaml
@@ -42,10 +42,18 @@ properties:
             description: The SDK version that was used.
           sdk_source:
             type: string
-            description: The SDK used to upload the media.	onfido-android-sdk, onfido-ios-sdk, onfido-web-sdk
+            enum:
+              - onfido-android-sdk
+              - onfido-ios-sdk
+              - onfido-web-sdk
+            description: The SDK used to upload the media.
           authentication_type:
             type: string
-            description: The token used to authenticate the request.	sdk_token, mobile_token, api_token
+            enum:
+              - sdk_token
+              - mobile_token
+              - api_token
+            description: The token used to authenticate the request.
           raw_model:
             type: string
             description: The model as set by the phone manufacturer (for Android and iOS) or the browser manufacturer (for Web). The model can be presented in name or number form depending on each manufacturer implementation.
@@ -82,20 +90,29 @@ properties:
             deprecated: true
           ip_reputation:
             type: string
+            enum:
+              - NOT_ENOUGH_DATA
+              - HIGH_RISK
+              - LOW_RISK
             description: Whether there is highly suspicious traffic related to the IP address. The risk depends on the overall ratio of clear checks on a given IP.
           device_fingerprint_reuse:
             type: integer
             description: The number of times the device was used to create a report for a new applicant. A value greater than 1 indicates potential device reuse.
           single_device_used:
-            # type: ['null', boolean]
             type: boolean
             description: Whether the document or biometric media were uploaded from a single device.
             nullable: true
           document_capture:
             type: string
+            enum:
+              - live
+              - unknown_method
             description: Whether the document media were live captured from the device camera.
           biometric_capture:
             type: string
+            enum:
+              - live
+              - unknown_method
             description: Whether the biometric media were live captured from the device camera.
       ip:
         type: object