Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: data races, multithreading improvements, compiler warnings #282

Merged
merged 39 commits into from
Jun 4, 2024
Merged

Fix: data races, multithreading improvements, compiler warnings #282

merged 39 commits into from
Jun 4, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented May 21, 2024 •
edited
Loading

Description

#168
#198

  • fixed most of the found problems with multithreading
    • noticeable improvements in download speed - it became more stable
    • the download speed dropping to 0 MB/s has gone away
    • the application became more stable, less crashes
  • resolved some compiler warnings

Testing

By @dnzbk:

  • Windows 11
  • Linux Debian 12
  • macOS Ventura
  • FreeBSD 14

By @phnzb:

  • Linux:
    • i686
    • x68_64
    • armhf
    • armel
    • aarch64
    • riscv64
  • Docker
  • Synology

dnzbk added 30 commits May 8, 2024 09:39
@dnzbk
atomize m_threadCount
9918ae2
@dnzbk
fix: include
fd108d2
@dnzbk
atomize g_Loaded
160cf04
@dnzbk
Merge branch 'develop' into fix/data-races
17f57b1
@dnzbk
atomize m_force
7d26354
@dnzbk
atomize m_tempPauseDownload
5ca4db1
@dnzbk
atomize �m_tempPausePostprocess
bd9848e
@dnzbk
atomize other bool members
694c5e8
@dnzbk
Fix: Thread data races
1f0d107
@dnzbk
atomize m_hasMoreJobs
af0f584
@dnzbk
atomize m_status
8bdf11d
@dnzbk
atomize m_lastWritten
9515285
@dnzbk
atomize �m_working
fac2d51
@dnzbk
Merge branch 'develop' into fix/data-races
0d37e20
@dnzbk
atomize WorkState
b5f2662
@dnzbk
Fix: scanner
01556a3
@dnzbk
atomize m_lastUpdateTime
94d505f
@dnzbk
atomize StatMeter
ee85dd2
@dnzbk
Fix: init
64f0833
@dnzbk
Fix: StatMeter
152d9d3
@dnzbk
Fix: m_speedBytesIndex
7d21985
@dnzbk
sync StatMeter
f2b7f4c
@dnzbk
atomize ScriptController
c409a2d
@dnzbk
Refactoring
6bcd20a
@dnzbk
use lock_guard
befebdd
@dnzbk
fix: type
34a750c
@dnzbk
revert
bb9e9a8
@dnzbk
Resolve compiler warnings
5c7bf71
@dnzbk
Fix: init
199dc64
@dnzbk
Fix: links
1ce224f
@dnzbk dnzbk linked an issue May 21, 2024 that may be closed by this pull request
Consider std::atomic over volatile #104
Closed
@dnzbk dnzbk marked this pull request as draft May 21, 2024 06:14
@dnzbk dnzbk requested review from phnzb and luckedea May 22, 2024 11:33
@luckedea luckedea changed the title Fix: data races, compiler warnings Fix: data races, multithread improvements, compiler warnings cleanup May 22, 2024
@dnzbk dnzbk changed the title Fix: data races, multithread improvements, compiler warnings cleanup Fix: data races, multithreading improvements, compiler warnings cleanup Jun 3, 2024
@dnzbk dnzbk changed the title Fix: data races, multithreading improvements, compiler warnings cleanup Fix: data races, multithreading improvements, compiler warnings Jun 3, 2024
@dnzbk dnzbk marked this pull request as ready for review June 3, 2024 10:32
@dnzbk dnzbk merged commit a98e6d1 into develop Jun 4, 2024
9 checks passed
@dnzbk dnzbk deleted the fix/data-races branch June 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phnzb phnzb phnzb approved these changes

@luckedea luckedea Awaiting requested review from luckedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider std::atomic over volatile
2 participants
@dnzbk @phnzb