Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider std::atomic over volatile #104

Closed
animetosho opened this issue Apr 30, 2023 · 0 comments · Fixed by #282
Closed

Consider std::atomic over volatile #104

animetosho opened this issue Apr 30, 2023 · 0 comments · Fixed by #282
Assignees
@dnzbk
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@animetosho
Copy link

I just happened to notice that a cross-thread flag is declared volatile, however volatile doesn't guarantee thread safety.

For extra safety, I suggest using std::atomic with acquire/release ordering instead.
@paul-chambers paul-chambers self-assigned this May 1, 2023
@paul-chambers paul-chambers transferred this issue from nzbget-ng/nzbget Jan 7, 2024
@paul-chambers paul-chambers removed their assignment Jan 11, 2024
@phnzb phnzb transferred this issue from another repository Jan 11, 2024
@luckedea luckedea added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jan 12, 2024
@dnzbk dnzbk linked a pull request May 21, 2024 that will close this issue
Fix: data races, multithreading improvements, compiler warnings #282
Merged
@dnzbk dnzbk closed this as completed in #282 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnzbk dnzbk

Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: data races, multithreading improvements, compiler warnings nzbgetcom/nzbget
4 participants
@paul-chambers @animetosho @luckedea @dnzbk