-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Automation in Windows Console: add "API levels" as a better isImprovedTextRangeAvailable #12660
Conversation
Cc @carlos-zamora, @DHowett. |
4c0bfe9
to
e5ed7ce
Compare
e5ed7ce
to
1a52c8a
Compare
Also CC @seanbudd. |
Would it be possible to determine the correct behavior based on the version of conhost available on the system? |
According to the conhost devs, version number is no longer a reliable indicator of functionality. |
Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, looks good to me
I think this is such a good way to do this. I'm always an advocate for feature detection rather than versioning, especially since Windows' servicing story makes it ... difficult to pin down precise time ranges 😄. Thanks @codeofdusk! |
Link to issue number:
None.
Summary of the issue:
The Windows 11 inbox console will ship with most, but not all, fixes required to make UIA by default a good experience. However, a new conhost version will be delivered "out-of-box" including additional functionality and bug fixes. Therefore,
isImprovedTextRangeAvailable
(a boolean value) is now insufficient to express the range of possible UIA console versions now in the wild.Description of how this pull request fixes the issue:
WinConsoleAPILevel
, with comments describing the meaning of each member.isImprovedTextRangeAvailable
, but refactor it for now to useapiLevel
.Testing strategy:
Tested conhost versions meeting each API level and verified that the correct level was being set.
Known issues with pull request:
FORMATTED
level is intentionally unused in NVDA code, usage to follow in subsequent PRs.FORMATTED
consoles are correctly detected when run though.Change log entries:
== Changes for Developers ==
NVDAObjects.UIA.winConsoleUIA.WinConsoleUIA.isImprovedTextRangeAvailable
has been deprecated. (UI Automation in Windows Console: add "API levels" as a better isImprovedTextRangeAvailable #12660)apiLevel
(see the comments at _UIAConstants.WinConsoleAPILevel for details).Code Review Checklist: