Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): pass ssr condition to getModuleByUrl #7260

Merged
merged 1 commit into from
Sep 5, 2022
Merged

fix(vite): pass ssr condition to getModuleByUrl #7260

merged 1 commit into from
Sep 5, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

#6649

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a missing condition to getModuleByUrl

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 5, 2022
@danielroe danielroe requested a review from pi0 September 5, 2022 20:47
@danielroe danielroe self-assigned this Sep 5, 2022
@netlify
Copy link

netlify bot commented Sep 5, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 5d0ad28
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63166053387f350008090cc1

pi0
pi0 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@pi0 pi0 changed the title fix: pass ssr condition to getModuleByUrl fix(vite): pass ssr condition to getModuleByUrl Sep 5, 2022
@pi0 pi0 merged commit d115b01 into main Sep 5, 2022
@pi0 pi0 deleted the fix/warmup-condition branch September 5, 2022 20:52
This was referenced Sep 9, 2022
Merged
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0