Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): warmup server entries with ssr condition #6649

Merged
merged 2 commits into from
Aug 15, 2022
Merged

fix(vite): warmup server entries with ssr condition #6649

merged 2 commits into from
Aug 15, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 15, 2022 •
edited

🔗 Linked issue

#6647

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Without this fix, we were actually adding some overhead to transform server assets without ssr condition.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 15, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 6a9de1f
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fa6e2d9da9d1000845ec4b

@pi0 pi0 requested a review from antfu August 15, 2022 15:34
@pi0 pi0 mentioned this pull request Aug 15, 2022
Closed
7 tasks
@pi0 pi0 merged commit 58c4753 into main Aug 15, 2022
@pi0 pi0 deleted the fix/vite-ssr-warmup branch August 15, 2022 16:03
@pi0 pi0 mentioned this pull request Aug 26, 2022
Merged
@danielroe danielroe mentioned this pull request Sep 5, 2022
Merged
7 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pi0 @antfu @danielroe