This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): include tag attrs for non self-closing tags in tree-shake regex #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
reviewed
Aug 16, 2022
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
approved these changes
Aug 16, 2022
|
Thanks @huang-julien @danielroe <3 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolve nuxt/nuxt#14606
❓ Type of change
📚 Description
Hi, this PR aims to add missing attributes when the tag is not a self-closing tag by fixing the regex. Previously, attributes were missing on non self-closing tags.
Test fixtures of this PR can be considered as included by PR #6584 ?
📝 Checklist