-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(nuxt): pass params to client-only slot #6584
Conversation
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
You are quick! |
@danielroe thank you! π |
Thanks for the quick fix! I'm wondering if we could add a test page to basic fixture to ensure this behavior keeps working. |
yes i think so, i can do it if you want (monday). I'm not sure about this but does nuxt test utils compile the SFCs to simulate a behavior in prod ? 2 different SFC needs to be tested:
|
Yes. test fixture is being compiled and built before running tests. We can have a dedicated page for test suite. |
@pi0 I might have an issue with the tests. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks <3
π Linked issue
resolve nuxt/nuxt#14563
β Type of change
π Description
nuxt/nuxt#14563 Boom.client component compilation: SFC playground (See SSR part line 33)
In #6165 the params of the setupState (when it is a function) were ignored.
framework/packages/nuxt/src/app/components/client-only.mjs
Lines 47 to 50 in 2ec2d9b
This PR make the setupState render function reproduce the same behavior when overriding the render option of the component here:
framework/packages/nuxt/src/app/components/client-only.mjs
Lines 23 to 29 in 2ec2d9b
You can test this here https://github.com/huang-julien/nuxt-3/tree/test/client-slot-fix
π Checklist