This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): remove /@fs from external ids
#6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
added
the
❗ p4-important
antfu
approved these changes
Aug 11, 2022
|
Have you checked on a built, separate Windows project? (Not WSL?) |
|
I can double check on edge but should be fine as could see in code with wrapper. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves nuxt/nuxt#14541
❓ Type of change
📚 Description
Regression might have appeared with #6355. When checking for external paths,
@fs/prefix should be omited as is a vite-specific prefix. Windows paths are still safe since with havepathToFileURLfor generating import statements.📝 Checklist