Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): use url for entry on windows #6355

Merged
merged 4 commits into from
Aug 4, 2022
Merged

fix(vite): use url for entry on windows #6355

merged 4 commits into from
Aug 4, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14370

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This resolves the entry path via a file URL on Windows to skip vite trying to resolve it as an import from nuxt3 directly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite windows ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Aug 4, 2022
@danielroe danielroe requested a review from pi0 August 4, 2022 12:08
@danielroe danielroe self-assigned this Aug 4, 2022
@netlify
Copy link

netlify bot commented Aug 4, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 3ddc24b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ebd2a79b007900081f84cf

@danielroe danielroe marked this pull request as draft August 4, 2022 12:09
packages/vite/src/vite.ts Outdated Show resolved Hide resolved
@danielroe danielroe marked this pull request as ready for review August 4, 2022 14:07
@danielroe danielroe requested a review from pi0 August 4, 2022 14:19
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@pi0 pi0 merged commit 463c15e into main Aug 4, 2022
@pi0 pi0 deleted the fix/windows-vite-entry branch August 4, 2022 15:24
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf vite windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "./dist/app/entry" export in "nuxt3" package
2 participants