Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): clear errors after navigation #4839

Merged
merged 2 commits into from
May 6, 2022
Merged

fix(nuxt): clear errors after navigation #4839

merged 2 commits into from
May 6, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

extracted fixes from #4539

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR fixes an issue where users who manually throw 404s can't escape from the error page (by clearing error after navigating to new route)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 6, 2022
@danielroe danielroe requested a review from pi0 May 6, 2022 09:32
@danielroe danielroe self-assigned this May 6, 2022
@netlify
Copy link

netlify bot commented May 6, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 58a94b1
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6274f60ec25ca8000840f0ea

@pi0 pi0 merged commit 27d6736 into main May 6, 2022
@pi0 pi0 deleted the fix/error-404 branch May 6, 2022 10:50
@pi0 pi0 mentioned this pull request May 6, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0