This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(nuxt): improve error dx for users #4539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pi0
reviewed
Apr 22, 2022
Co-authored-by: pooya parsa <pyapar@gmail.com>
Co-authored-by: pooya parsa <pyapar@gmail.com>
Co-authored-by: pooya parsa <pyapar@gmail.com>
Co-authored-by: pooya parsa <pyapar@gmail.com>
pi0
reviewed
Apr 22, 2022
misaon
reviewed
Apr 22, 2022
Aareksio
reviewed
Apr 22, 2022
This was referenced May 6, 2022
pi0
reviewed
Jun 15, 2022
Currently,
(*) Graceful client handling: Showing full-error page for Client-Side, is really unnecessary in many cases. For example, when a refresh button fails, we can avoid bailing the whole application into an error state. Using Error boundary is probably best but it is harder to use. |
7 tasks
* throwError falls back to normal error even if no context
pi0
approved these changes
Jul 21, 2022
π₯ |
2 tasks
This was referenced Aug 5, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
enhancement
New feature or request
π¨ p3-minor-bug
Priority 3: a bug in an edge case that only affects very specific usage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#13788, resolves nuxt/nuxt#13950
β Type of change
π Description
This PR improves the error experience for users:
throwError
toshowError
and allows graceful fallback when nuxt context is not availableshowError
to acceptcreateError
params for better dxcreateError
within the Vue lifecycle. (π This is now the recommended approach.) This is similar to usingcreateError
in server api routes. On server side these will lead to a full page error, but on client can be handled with error boundaries,onErrorCaptured
, and so on.π Checklist