VCR: Don't check VC existence when revoking #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenvegt
requested changes
Feb 21, 2023
|
Failing end-to-end test is the secret storage (Vault) test, which is feature not availaible in v5.0.x. Running test suite locally with that specific test disabled. |
stevenvegt
requested changes
Feb 21, 2023
stevenvegt
approved these changes
Feb 21, 2023
reinkrul
added a commit
that referenced
this pull request
Feb 21, 2023
* VCR: Don't check VC existence when revoking * Release notes * godoc * Add check for credential ID format
reinkrul
added a commit
that referenced
this pull request
Feb 22, 2023
* VCR: Don't check VC existence when revoking * Release notes * godoc * Add check for credential ID format
reinkrul
added a commit
that referenced
this pull request
Feb 22, 2023
* VCR: Don't check VC existence when revoking * Release notes * godoc * Add check for credential ID format
reinkrul
added a commit
that referenced
this pull request
Feb 22, 2023
* VCR: Don't check VC existence when revoking * Release notes * godoc * Add check for credential ID format
reinkrul
added a commit
that referenced
this pull request
Feb 22, 2023
* VCR: Don't check VC existence when revoking * Release notes * godoc * Add check for credential ID format
reinkrul
added a commit
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1911
Also needs to be applied to master branch.