Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost issuer DB prevents revoking of issued credentials #1911

Closed
woutslakhorst opened this issue Feb 20, 2023 · 3 comments · Fixed by #1917
Closed

Lost issuer DB prevents revoking of issued credentials #1911

woutslakhorst opened this issue Feb 20, 2023 · 3 comments · Fixed by #1917
Labels
bug Something isn't working vcr

Comments

@woutslakhorst
Copy link
Member

issued credentials are stored in the issuer db and the vcr. If you lose your issuer db, the network will send you a copy to the vcr. At that point you can see and use the vc but you can no longer revoke it.

"lost" credentials recovered from the network should find their way back into the issuer DB.

@woutslakhorst woutslakhorst added bug Something isn't working vcr labels Feb 20, 2023
@reinkrul reinkrul removed the bug Something isn't working label Feb 21, 2023
@reinkrul
Copy link
Member

As designed; database should be backed up. But we could introduce a "rebuild" feature; finding all credentials issued by specified issuer, put them in issuer DB.

Maybe we could reconsider the issuer DB and make it more resilient, either by completely eliminating it (always work on VCs received over network, which may not be feasible for private VCs), or making it more like "volatile" storage.

@woutslakhorst
Copy link
Member Author

But we could introduce a "rebuild" feature; finding all credentials issued by specified issuer, put them in issuer DB.

Required since a backup could be missing some VCs but the network already has them. It's hole in the 'feature'.

@woutslakhorst woutslakhorst added the bug Something isn't working label Feb 21, 2023
@reinkrul
Copy link
Member

The easiest fix is to not check for credential existence. Fix on v5 and release patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vcr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants