Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: npm@6.10.0 #205

Merged
merged 37 commits into from
Jul 3, 2019
Merged

Release: npm@6.10.0 #205

merged 37 commits into from
Jul 3, 2019

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jun 29, 2019

v6.10.0 (TBD):

FEATURES

BUGFIXES

TESTING

DOCUMENTATION

DEPENDENCIES

@isaacs isaacs force-pushed the release-next-6.10.0 branch 3 times, most recently from dcf460b to ce38c46 Compare June 29, 2019 23:32
isaacs and others added 27 commits June 29, 2019 20:23
This fixes a ERR_INVALID_OPT_VALUE error on Node v12
Several changes to the test suite to support running tests in parallel,
bringing the overall test time down considerably.

- Replace all literal 1337 and 1234 ports with a custom per-process port
  assignment based on the TAP_CHILD_ID environment variable.
- Add common.pkg as a per-test working directory instead of polluting
  __dirname or accidentally reusing the same working directory for
  multiple tests.
- Rework test config handling so that tests don't rely on config setup
  being run in a particular order.
- Remove the npm-registry-couchapp tests, since it (a) relies on
  CouchDB, (b) is no longer a reliable indicator of registry
  compatibility, and (c) is already superceded in most cases by tests
  that use npm-registry-mock.  (A test suite that runs against a
  reference implementation is a thing that should exist, but not here.)
- Remove the fake-registry logging when TAP_CHILD_ID is set, since this
  is extremely hard to make sense of when running multiple tests in
  parallel.

When Node v6 compatibility is dropped in npm v7, we can upgrade to the
latest version of tap for a bit more speed, dropping Domains (and the
associated deprecation warnings), and a fancier test reporter.
Add a special case for 'remote' deps (tarballs). Before
b7b54f2 the package names were possibly
just looked up in the registry instead.

See https://npm.community/t/6187

Close: #180
-a tells git to "ignore the git config for signing tags"

that is all it does.

Close: #185

Note: SemVer minor -- @isaacs
implementation added in #31
I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions!  Assumed that it would need to have the same syntax as when running `npm install`.  Thought this would be a good contribution for future readers.
Signed-off-by: ossdev <ossdev@puresoftware.com>
npm find local node.exe on windows, but relies on global node
installation on linux. Added a test to check for a local installation of
node before relying on the system wide installation.

Close: #200
Note: SemVer minor -- @isaacs

Close: #202
Never include /.git in the package.  It creates packages that, once
installed, can not be easily removed.

Prevent .DS_Store files from being picked up if they are files rather
than folders.  (Note that a .DS_Store file in a specifically included
dir _will_ still be included.)

Don't bother walking node_modules in the root if no packages are
bundled.  (Saves thousands of lstat calls on npm publish in normal
cases.)

Sort package file lists in the tarball to optimize for gzip compression.
Fixes a bug related to FSReqWrap on Node v12, and incorrect
encoding/decoding of base-256 numeric values.
Fix: npm/npm#17858
Fix: npm/npm#18042
Fix: https://npm.community/t/issue-npm-dedupe-crash-with-typeerror-cannot-read-property-0-of-undefined/644/3
Close: #201

This fixes a bug where a package folder might have a package.json which
is missing or lacks a name property.  It also properly detects the
scoped-ness of a package folder even if the package name is not scoped,
since one might install `express@npm:@scope/express` and end up in that
state.
Close: #176

EDIT: Added test, do not set exitStatus to 1 if we're just printing an
empty list as JSON. -- @isaacs
Total luxury problem.  There are too many cores on my laptop, so
commands kick off and complete too quickly, resulting in not properly
demonstrating the behavior that this test is looking for.
@isaacs isaacs force-pushed the release-next-6.10.0 branch 2 times, most recently from 4b83db6 to 42bd015 Compare July 1, 2019 04:51
@isaacs isaacs marked this pull request as ready for review July 1, 2019 04:52
@isaacs isaacs requested a review from a team as a code owner July 1, 2019 04:52
@isaacs isaacs changed the title Release next 6.10.0 Release: 6.10.0 Jul 1, 2019
Missed this on the review.  Minor nit, not worth rebasing, now that the
release is almost ready to ship.
@isaacs isaacs changed the title Release: 6.10.0 Release: npm@6.10.0 Jul 1, 2019
@zkat zkat added the release label Jul 1, 2019
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.