Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of bundledDependencies #192

Closed
wants to merge 1 commit into from

Conversation

john-osullivan
Copy link
Contributor

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions! Assumed that it would need to have the same syntax as when running npm install. Thought this would be a good contribution for future readers.

I spent a couple hours debugging the fact that package names in that key aren't supposed to include their versions!  Assumed that it would need to have the same syntax as when running `npm install`.  Thought this would be a good contribution for future readers.
@john-osullivan john-osullivan requested a review from a team as a code owner April 24, 2019 22:57
@isaacs isaacs mentioned this pull request Jul 1, 2019
@isaacs isaacs closed this Jul 10, 2019
@ljharb
Copy link
Contributor

ljharb commented Jul 10, 2019

Landed in f5857e263?

@isaacs
Copy link
Contributor

isaacs commented Jul 10, 2019

That is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants