fix: modify module loader to look in parent directories #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 92.40% 91.98% -0.42%
==========================================
Files 9 9
Lines 250 262 +12
==========================================
+ Hits 231 241 +10
- Misses 19 21 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lance
commented
Dec 16, 2022
matejvasek
reviewed
Dec 16, 2022
matejvasek
reviewed
Dec 16, 2022
lance
force-pushed
the
143-esm-on-typescript
branch
3 times, most recently
from
1404d20
to
88716a4
Compare
|
@matejvasek @lholmquist I've added windows compatibility and tests - ptal |
This resolves issues where function source may be in a subdirectory, for example `./build` in a TypeScript project. Fixes: nodeshift#143 Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
143-esm-on-typescript
branch
from
d936f51
to
e4a3d19
Compare
|
/lgtm |
lholmquist
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues where function source may be in a subdirectory, for example
./buildin a TypeScript project.Fixes: #143
Signed-off-by: Lance Ball lball@redhat.com