-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(node,typescript): update dependencies #1468
Conversation
Codecov ReportBase: 63.15% // Head: 63.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
+ Coverage 63.15% 63.41% +0.25%
==========================================
Files 74 75 +1
Lines 10806 10808 +2
==========================================
+ Hits 6825 6854 +29
+ Misses 3423 3398 -25
+ Partials 558 556 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I don't know why the on-cluster tests are failing... |
@lance some were probably flakes,
|
maybe build part is not run? |
/cc @lholmquist |
@matejvasek: GitHub didn't allow me to request PR reviews from the following users: lholmquist. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @lholmquist |
Does one need specific node version? |
@matejvasek thanks for looking into this. The problem is the ESM module loader that landed in this nodeshift/faas-js-runtime#140. It assumes there is a |
/hold for nodeshift/faas-js-runtime#144 |
8cb9d10
to
55546d1
Compare
/unhold |
Updates dependencies in Node.js and TypeScript functions to eliminate some security warnings and bump to faas-js-runtime 0.9.7, which allows for ESM modules now. Signed-off-by: Lance Ball <lball@redhat.com>
55546d1
to
ec8dcbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates dependencies in Node.js and TypeScript functions to eliminate some security warnings and bump to faas-js-runtime 0.9.7, which allows for ESM modules now. Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Lance Ball <lball@redhat.com>
Updates dependencies in Node.js and TypeScript functions to eliminate some security warnings and bump to faas-js-runtime 0.9.7, which allows for ESM modules now.
Signed-off-by: Lance Ball lball@redhat.com
/kind chore