Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Killing the process hangs after a browser request #120

Closed
lance opened this issue Jul 13, 2022 · 2 comments · Fixed by #172, #149 or knative/func#1570
Closed

Killing the process hangs after a browser request #120

lance opened this issue Jul 13, 2022 · 2 comments · Fixed by #172, #149 or knative/func#1570
Assignees
@helio-frota
Labels
bug Something isn't working

Comments

@lance
Copy link
Member

lance commented Jul 13, 2022

See https://gist.github.com/BethGriggs/2a6d0227b2747ecb72ff6d5eeb4d7977?permalink_comment_id=4221848#gistcomment-4221848
@lance lance added the bug Something isn't working label Jul 13, 2022
@helio-frota helio-frota self-assigned this Feb 3, 2023
@helio-frota
Copy link
Member

helio-frota commented Feb 3, 2023 •
edited
Loading

Solved in node 18.14.0
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.14.0
nodejs/node#41578

UPDATE: this is a different (almost the same thing but not equal) issue

👍

@helio-frota
Copy link
Member

please don't close, I tested again and this is not 100% working...

@helio-frota helio-frota mentioned this issue Feb 4, 2023
Closed
@lance lance mentioned this issue Feb 14, 2023
Merged
lance pushed a commit that referenced this issue Feb 14, 2023
@helio-frota
fix: killing the process hangs issue (#172)
3ac8b9d 
Ensure quick shutdown when browsers are holding open a connection.

Fixes: #120
@github-actions github-actions bot mentioned this issue Feb 14, 2023
Merged
lance added a commit to lance/func that referenced this issue Feb 20, 2023
@lance
chore: update faas-js-runtime to 0.10.0
14c1b12 
Fixes: nodeshift/faas-js-runtime#120

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance mentioned this issue Feb 20, 2023
Merged
knative-prow bot pushed a commit to knative/func that referenced this issue Feb 20, 2023
@lance
chore: update faas-js-runtime to 0.10.0 (#1570)
c20c887 
* chore: update faas-js-runtime to 0.10.0

Fixes: nodeshift/faas-js-runtime#120

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: try ignoring package-lock.json files in linter

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: actually add package-lock.json

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: better globbing

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: best globbing

Signed-off-by: Lance Ball <lball@redhat.com>

---------

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helio-frota helio-frota

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@lance @helio-frota