Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update faas-js-runtime to 0.10.0 #1570

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

lance
Copy link
Member

@lance lance commented Feb 20, 2023

Fixes: nodeshift/faas-js-runtime#120

Fixes an issue where Node.js and TypeScript functions are not killed immediately on SIGHUP

/kind chore

Fixes: nodeshift/faas-js-runtime#120

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 60.21% // Head: 60.51% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (9b68e41) compared to base (df819d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   60.21%   60.51%   +0.30%     
==========================================
  Files          75       76       +1     
  Lines       10307    10310       +3     
==========================================
+ Hits         6206     6239      +33     
+ Misses       3530     3500      -30     
  Partials      571      571              
Flag Coverage Δ
integration-tests 50.85% <ø> (-0.06%) ⬇️
unit-tests ?
unit-tests-macos-latest 49.44% <ø> (?)
unit-tests-ubuntu-latest 50.95% <ø> (?)
unit-tests-windows-latest 49.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/knative/deployer.go 62.46% <0.00%> (-0.42%) ⬇️
pkg/docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
pkg/functions/client.go 59.21% <0.00%> (+0.55%) ⬆️
pkg/docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
pkg/docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/approve
/lgmt

@knative-prow
Copy link

knative-prow bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member Author

lance commented Feb 20, 2023

/approve /lgmt

@matejvasek can you fix the typo here? :)

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@matejvasek
Copy link
Contributor

@lance you either:
a) skip Code Style / style / Lint
b) put package-lock.json files to some linter ignore file.

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@lance

This comment was marked as outdated.

@knative-prow

This comment was marked as outdated.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance

This comment was marked as outdated.

@knative-prow

This comment was marked as outdated.

@lance

This comment was marked as outdated.

@knative-prow

This comment was marked as outdated.

@lance
Copy link
Member Author

lance commented Feb 20, 2023

/override "style / Lint"

@knative-prow
Copy link

knative-prow bot commented Feb 20, 2023

@lance: Overrode contexts on behalf of lance: style / Lint

In response to this:

/override "style / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@knative-prow knative-prow bot merged commit c20c887 into knative:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Killing the process hangs after a browser request
2 participants